Crash after closing a tooltip's Popup directly #5932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
singhashish-wpf
approved these changes
Jan 19, 2022
singhashish-wpf
added a commit
to SamBent/wpf
that referenced
this pull request
Jan 27, 2022
singhashish-wpf
added a commit
that referenced
this pull request
Feb 1, 2022
* make SafeArea check work when capture is active * Update and sync changes with main and #5932 Co-authored-by: Ashish Kumar Singh <SINGHASHISH@MICROSOFT.COM>
singhashish-wpf
added a commit
that referenced
this pull request
Feb 7, 2022
dipeshmsft
pushed a commit
that referenced
this pull request
Feb 7, 2022
…6063) * ToolTips in popups (or any context where capture is active) (#5931) * make SafeArea check work when capture is active * Update and sync changes with main and #5932 Co-authored-by: Ashish Kumar Singh <SINGHASHISH@MICROSOFT.COM> * Fix merge errors for #5931 and #5932 (#6078) * update to make same changes as 5931 Co-authored-by: Sam Bent <sambent@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5730
Description
Closing a tooltip's Popup directly (as opposed to closing the ToolTip and letting WPF close the Popup in response) causes WPF to clear some private state on the ToolTip while leaving its IsOpen=true. When the ToolTip is eventually closed, WPF uses that state and crashes because it's null.
Fixed by preserving the private state until the ToolTip itself is closed, and adding logic to ensure that the state is cleared even if the Popup was already closed before the ToolTip closed.
Customer Impact
Fixes a regression.
Regression
Yes.
Testing
Risk
Low. The fix itself is safe. The customer reports did not include repros, so there's a small risk that there are crashing scenarios that this fix doesn't address.